Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use julia implementations for pdfs and some cdf-like functions #113

Merged
merged 34 commits into from
Feb 18, 2022
Merged

Use julia implementations for pdfs and some cdf-like functions #113

merged 34 commits into from
Feb 18, 2022

Commits on Jan 29, 2022

  1. Use Julia implementations for (log)pdfs. Adjust Rmath tests to use 

    testsets to give more informative errors.
    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    139d141 View commit details
    Browse the repository at this point in the history

  2. Use Julia implementations for most cdf-like functions of the Chisq 

    distribution.
    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    0bffee8 View commit details
    Browse the repository at this point in the history

  3. Change Beta distribution to be using native implementations.

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    6bfc68d View commit details
    Browse the repository at this point in the history

  4. Switch binomial cdfs to use native implementations (but not the inver… 

    …ses)
    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    60b64f3 View commit details
    Browse the repository at this point in the history

  5. Use native implementations for most cdf like gamma functions

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    542a6c4 View commit details
    Browse the repository at this point in the history

  6. Just use the gamma defitions for the chisq

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    6d66ba3 View commit details
    Browse the repository at this point in the history

  7. Use the beta definitions for binomial

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    15b321c View commit details
    Browse the repository at this point in the history

  8. Add native implementions for Poisson's cdf-like functions

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    49178c2 View commit details
    Browse the repository at this point in the history

  9. Rely on SpecialFunctions promotion handling in beta functions

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    6366eab View commit details
    Browse the repository at this point in the history

  10. Rely on gamma_inc_inv promotion in gammainv(c)cdf

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    b2ed6c9 View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @andreasnoack @devmotion
    andreasnoack and devmotion committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    15e20ff View commit details
    Browse the repository at this point in the history

  12. Add compat for HypergeometricFunctions

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    9c22066 View commit details
    Browse the repository at this point in the history

  13. Changes from review

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    fd4db7e View commit details
    Browse the repository at this point in the history

  14. Handle negative arguments in Poisson (log)(c)cdf

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    3c942e0 View commit details
    Browse the repository at this point in the history

  15. Handle negative x in Gamma (log)(c)cdf

    @andreasnoack
    andreasnoack committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    7c67a0d View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2022

  1. Handle arguments outside support for Beta and Fdist (log)(c)cdf

    @andreasnoack
    andreasnoack committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    90a6404 View commit details
    Browse the repository at this point in the history

  2. Fix Fdist quantile functions

    @andreasnoack
    andreasnoack committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    0a54399 View commit details
    Browse the repository at this point in the history

  3. Handle arguments out of support in Binomial (log)(c)cdf and apply 

    the floor function to make the results correct for non-integer arguments
    @andreasnoack
    andreasnoack committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    8cd5a76 View commit details
    Browse the repository at this point in the history

  4. Avoid accidental promotion to Float64 in fdist(log)(c)cdf

    @andreasnoack
    andreasnoack committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    73f20b7 View commit details
    Browse the repository at this point in the history

  5. Fix typo in "x" calculation for fdist(log)(c)cdf

    @andreasnoack
    andreasnoack committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    71025f9 View commit details
    Browse the repository at this point in the history

  6. Drop redundant low tolerance tests for Beta(1000, 2). We are now 

    generally more accurate than Rmath so failure are because of Rmath.
    @andreasnoack
    andreasnoack committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    5a8d121 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Handle some non-finite edge cases in gamma and binomial

    @andreasnoack
    andreasnoack committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    60ca443 View commit details
    Browse the repository at this point in the history

  2. Only switch to log-version of betalogcdf when the result is tiny

    @andreasnoack
    andreasnoack committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    2578dbe View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2022

  1. Handle the degenerate cases in beta(log)(c)cdf when alpha is zero

    @andreasnoack
    andreasnoack committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    9ec4aef View commit details
    Browse the repository at this point in the history

  2. Handle the degenerate case of the gamma distribution when k==0. 

    Also, only calculate the log(c)cdf based on the hypergeometric
function when p is zero or subnormal
    @andreasnoack
    andreasnoack committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    99cd041 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Address review comments

    @andreasnoack
    andreasnoack committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    b031752 View commit details
    Browse the repository at this point in the history

  2. Avoid rational return type in gamma(log)(c)cdf

    @andreasnoack
    andreasnoack committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    f3ceda8 View commit details
    Browse the repository at this point in the history

  3. Update src/distrs/gamma.jl 

    Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @andreasnoack @devmotion
    andreasnoack and devmotion committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    beb5dcd View commit details
    Browse the repository at this point in the history

  4. Update src/distrs/beta.jl 

    Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @andreasnoack @devmotion
    andreasnoack and devmotion committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    14882a3 View commit details
    Browse the repository at this point in the history

  5. Update src/distrs/binom.jl 

    Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @andreasnoack @devmotion
    andreasnoack and devmotion committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    fbdb4eb View commit details
    Browse the repository at this point in the history

  6. Update src/distrs/gamma.jl 

    Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @andreasnoack @devmotion
    andreasnoack and devmotion committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    c3300d2 View commit details
    Browse the repository at this point in the history

  7. Update src/distrs/gamma.jl 

    Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @andreasnoack @devmotion
    andreasnoack and devmotion committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    46bd90d View commit details
    Browse the repository at this point in the history

  8. Update src/distrs/gamma.jl 

    Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @andreasnoack @devmotion
    andreasnoack and devmotion committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    af14aba View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Handle the case when alpha and beta are zero in the betacdf

    @andreasnoack
    andreasnoack committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    cb1f325 View commit details
    Browse the repository at this point in the history