Add warning for package developers to README #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbesancon
reviewed
Feb 11, 2019
|
Do you feel like developing? |
|
Yes, I'll try to add to the PR later in the evening |
|
feel free to modify the modification :) |
|
I can't see it... :-/ |
|
Nor can I. @matbesancon, perhaps you forgot to |
matbesancon
reviewed
Feb 12, 2019
|
|
||
|
|
||
| This package is intended for users of statistics packages. Packages themselves should continue | ||
| to list individual packages in they dependencies rather than `StatsKit` as a whole. |
There was a problem hiding this comment.
Suggested change
| to list individual packages in they dependencies rather than `StatsKit` as a whole. | |
| to list individual packages in they dependencies rather than `StatsKit` as a whole | |
| to avoid depending on too many packages, blocking their upgrade. |
|
oh this review interface tricked me again. Sorry! Since these are minor things I put them as suggestions instead of a commit |
Co-Authored-By: nalimilan <nalimilan@club.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.