Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIP REQUIRE, hello Project.toml #104

Merged
merged 1 commit into from
May 20, 2019
Merged

RIP REQUIRE, hello Project.toml #104

merged 1 commit into from
May 20, 2019

Conversation

kleinschmidt
Copy link
Member

In preparation for tagging a release, this replaces REQUIRE and test/REQUIRE with Project.toml

@ararslan
Copy link
Member

Needs a version underneath uuid in order to be tagged, otherwise LGTM if CI agrees

@kleinschmidt
Copy link
Member Author

And just to be clear, merging a Project.toml with a version is not enough to trigger the registration bot right? THat requires a manual step?

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   84.49%   84.49%           
=======================================
  Files           8        8           
  Lines         458      458           
=======================================
  Hits          387      387           
  Misses         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861a222...d40328e. Read the comment docs.

@ararslan
Copy link
Member

Correct. You do at-JuliaRegistrator register() and it uses the version in Project.toml to make a PR against the General registry, then once that's merged, TagBot makes a tag for the version on the repo.

@kleinschmidt kleinschmidt merged commit 2d33e25 into master May 20, 2019
@ararslan ararslan deleted the dfk/project branch May 20, 2019 18:24
@ararslan
Copy link
Member

Still needs a version...

@kleinschmidt
Copy link
Member Author

well I'm a moron. time to make another PR like an idiot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants