Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for ShiftedArrays to 2, (keep existing compat) #264

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 14, 2022

This pull request changes the compat entry for the ShiftedArrays package from 1 to 1, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Closes #265

@kleinschmidt kleinschmidt force-pushed the compathelper/new_version/2022-09-14-01-30-19-605-01194743581 branch from 8875bc7 to e33bf1d Compare September 14, 2022 01:30
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI ran with ShiftedArrays v2 so this should be safe.

@ararslan
Copy link
Member

Quoting Pietro in Slack,

Only relevant change should be unexporting of lag and lead, but it seems that StatsModels imports them explicitly, so there shouldn't be issues

@ararslan ararslan merged commit cc3a925 into master Sep 17, 2022
@ararslan ararslan deleted the compathelper/new_version/2022-09-14-01-30-19-605-01194743581 branch September 17, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version of ShiftedArrays in Project.toml [compat]
1 participant