Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtd #174

Merged
merged 9 commits into from Mar 5, 2015
Merged

Rtd #174

merged 9 commits into from Mar 5, 2015

Conversation

milktrader
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.13% when pulling b70fba0 on rtd into b8cf905 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.13% when pulling dea9524 on rtd into b8cf905 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.13% when pulling dea9524 on rtd into b8cf905 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.45%) to 75.68% when pulling dea9524 on rtd into b8cf905 on master.

@ghost
Copy link

ghost commented Mar 5, 2015

Since everything in /_build Is generated from the make script, does it need to be committed to the repository?

@milktrader
Copy link
Contributor Author

I'm not sure and the answer is probably no. How would you handle this? Add it to .gitignore or just remove it before committing?

milktrader pushed a commit that referenced this pull request Mar 5, 2015
@milktrader milktrader merged commit 6903b24 into master Mar 5, 2015
@milktrader milktrader deleted the rtd branch March 5, 2015 03:10
@milktrader
Copy link
Contributor Author

Hmm, I see that readthedocs can't build it the way it's presently laid out. It clearly doesn't care what's in the _build directory.

@ghost
Copy link

ghost commented Mar 5, 2015

I would probably do both so no one else makes the same commit again. :)

On Mar 4, 2015, at 7:09 PM, milktrader notifications@github.com wrote:

I'm not sure and the answer is probably no. How would you handle this? Add it to .gitignore or just remove it before committing?


Reply to this email directly or view it on GitHub.

@milktrader
Copy link
Contributor Author

#176

@milktrader
Copy link
Contributor Author

thanks @MrTomWhite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants