Update split.rst #307
Closed
Update split.rst #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update eltype(green) and eltype(red) to appropriate types
ararslan
reviewed
Mar 14, 2017
| @@ -119,7 +119,7 @@ The ``findwhen`` method test a condition and returns a vector of ``Date`` or ``D | |||
| julia> green = findwhen(ohlc["Close"] .> ohlc["Open"]); | |||
|
|
|||
| julia> typeof(green) | |||
| Array{Date,1} | |||
| Vector{Date} | |||
There was a problem hiding this comment.
This isn't correct. The type system doesn't know what a Vector is; it's just a type alias. Regular Arrays always print as Array{T,N}.
|
Oh, my mistake then.
Thanks a lot for the clarification!
Will try to be more careful next time.
…-mrg
Am 13.03.2017 um 18:01 schrieb Alex Arslan ***@***.***>:
@ararslan commented on this pull request.
In docs/source/split.rst:
> @@ -119,7 +119,7 @@ The ``findwhen`` method test a condition and returns a vector of ``Date`` or ``D
julia> green = findwhen(ohlc["Close"] .> ohlc["Open"]);
julia> typeof(green)
- Array{Date,1}
+ Vector{Date}
This isn't correct. The type system doesn't know what a Vector is; it's just a type alias. Regular Arrays always print as Array{T,N}.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
No problem. Thanks anyway for the contribution! It's always good to know that people are willing to contribute, regardless of the outcome. 🙂 |
|
Will try to contribute some more as I keep working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update eltype(green) and eltype(red) to appropriate types