Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine: hcat support #341

Merged
merged 1 commit into from
Nov 29, 2017
Merged

combine: hcat support #341

merged 1 commit into from
Nov 29, 2017

Conversation

iblislin
Copy link
Collaborator

@iblislin iblislin commented Nov 4, 2017

For simple use case, it's faster than merge.
(merge serves as inner / outer join, which differs from hcat)

julia> @benchmark merge($cl, $ohlc)
BenchmarkTools.Trial:
  memory estimate:  210.75 KiB
  allocs estimate:  5122
  --------------
  minimum time:     273.470 μs (0.00% GC)
  median time:      279.141 μs (0.00% GC)
  mean time:        299.841 μs (5.72% GC)
  maximum time:     2.998 ms (79.71% GC)
  --------------
  samples:          10000
  evals/sample:     1

julia> @benchmark [$cl $ohlc]
BenchmarkTools.Trial:
  memory estimate:  58.14 KiB
  allocs estimate:  1360
  --------------
  minimum time:     77.604 μs (0.00% GC)
  median time:      80.881 μs (0.00% GC)
  mean time:        102.880 μs (6.02% GC)
  maximum time:     5.132 ms (90.05% GC)
  --------------
  samples:          10000
  evals/sample:     1

@JuliaStats JuliaStats deleted a comment from coveralls Nov 4, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 86.364% when pulling 1044400 on iblis17:hcat into 356cab1 on JuliaStats:master.

@iblislin iblislin added this to the 0.11.0 milestone Nov 4, 2017
@iblislin
combine: hcat support
5a6095b 
For simple use case, it's faster than `merge`.
(`merge` serves as inner / outer join, which differs from `hcat`)

```julia
julia> @benchmark merge($cl, $ohlc)
BenchmarkTools.Trial:
  memory estimate:  210.75 KiB
  allocs estimate:  5122
  --------------
  minimum time:     273.470 μs (0.00% GC)
  median time:      279.141 μs (0.00% GC)
  mean time:        299.841 μs (5.72% GC)
  maximum time:     2.998 ms (79.71% GC)
  --------------
  samples:          10000
  evals/sample:     1

julia> @benchmark [$cl $ohlc]
BenchmarkTools.Trial:
  memory estimate:  58.14 KiB
  allocs estimate:  1360
  --------------
  minimum time:     77.604 μs (0.00% GC)
  median time:      80.881 μs (0.00% GC)
  mean time:        102.880 μs (6.02% GC)
  maximum time:     5.132 ms (90.05% GC)
  --------------
  samples:          10000
  evals/sample:     1
```
@iblislin
Copy link
Collaborator Author

conflicting resolved.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 86.304% when pulling 5a6095b on iblis17:hcat into 2cb954e on JuliaStats:master.

@iblislin iblislin merged commit c0d319f into JuliaStats:master Nov 29, 2017
@iblislin iblislin deleted the hcat branch November 29, 2017 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iblislin @coveralls