Add copy function to TimeArray #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblislin
reviewed
Dec 20, 2017
src/timearray.jl
Outdated
| ###### copy ############### | ||
|
|
||
| copy(ta::TimeArray)::TimeArray = | ||
| TimeArray(ta.timestamp, ta.values, ta.colnames, ta.meta) |
There was a problem hiding this comment.
Could you make it 4-space indented?
iblislin
reviewed
Dec 20, 2017
| @@ -56,6 +56,11 @@ convert(::Type{TimeArray{Float64, 2}}, x::TimeArray{Bool, 2}) = | |||
| convert(x::TimeArray{Bool, 1}) = convert(TimeArray{Float64, 1}, x::TimeArray{Bool, 1}) | |||
| convert(x::TimeArray{Bool, 2}) = convert(TimeArray{Float64, 2}, x::TimeArray{Bool, 2}) | |||
|
|
|||
| ###### copy ############### | |||
|
|
|||
| copy(ta::TimeArray)::TimeArray = | |||
There was a problem hiding this comment.
I think our compiler is smart enough, and we do not need return type annotation here.
There was a problem hiding this comment.
Even if it is redundant, I prefer to annotate types as much as possible. But I will adapt to the style you prefer. Would you prefer to remove the output type?
There was a problem hiding this comment.
ok, I'm fine with current.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy base function is necessary to use the Bootstrap package.
The Bootstrap package will also need some changes, but this paves the way to being able to use both packages together.