Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace find -> findall and fix issue 432 #433

Merged
merged 9 commits into from
Oct 17, 2019

Conversation

Sh4pe
Copy link
Contributor

@Sh4pe Sh4pe commented Oct 9, 2019

The function find is not defined and caused an UndefVarError
when this line was executed.

Fixes #432

The function find is not defined and caused an UndefVarError
when this line was executed.
@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #433 into master will increase coverage by 1.36%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   85.89%   87.25%   +1.36%     
==========================================
  Files          11       11              
  Lines         475      510      +35     
==========================================
+ Hits          408      445      +37     
+ Misses         67       65       -2
Impacted Files Coverage Δ
src/plotrecipes.jl 14.54% <75%> (+14.54%) ⬆️
src/apply.jl 96.72% <0%> (-3.28%) ⬇️
src/combine.jl 98.48% <0%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee109af...576f451. Read the comment docs.

@iblislin iblislin self-requested a review October 13, 2019 04:48
@iblislin
Copy link
Collaborator

Hi @Sh4pe could you test the updated patches?

@iblislin iblislin self-assigned this Oct 13, 2019
@Sh4pe
Copy link
Contributor Author

Sh4pe commented Oct 15, 2019

It still does not work and fails inside extract_ohlc. I've added a test that invokes the Candlestick constructor and it fails with the error message

ArgumentError: invalid index: nothing of type Nothing

(The Julia 1.0 build job failed because it could not connect to GitHub. Maybe it needs to be rekicked).

@iblislin
Copy link
Collaborator

ah, I fixed the error message.
A Candlestick requires theses four columns as inputs: open, high, low, close.
A worked example:

using MarketData
TimeSeries.Candlestick(ohlcv)

@Sh4pe
Copy link
Contributor Author

Sh4pe commented Oct 16, 2019

Ok, got it. I like the solution - no more comments 😄

@iblislin
Copy link
Collaborator

Thanks for your contribution.

I'm going to make a new release.

@iblislin iblislin closed this Oct 17, 2019
@iblislin iblislin reopened this Oct 17, 2019
@iblislin iblislin merged commit aea2eea into JuliaStats:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting TimeArray with seriestype == :candlestick causes exception "UndefVarError: find not defined"
3 participants