Modified show, added omitted columns message #489
Conversation
|
I just found that |
src/timearray.jl
Outdated
| spacetime, colwidth, nrow, drow, res_row, tophalf, bothalf, | ||
| length(pages)) | ||
|
|
||
| if length(pages) > 1 |
There was a problem hiding this comment.
I think we need to support @show for printing all pages out.
There was a problem hiding this comment.
Yes, that would be great and it would take advantage of the paging machinery. I'm not sure how to do this, though; I tried looking at the DataFrames package and to @show df with a large DataFrame and it dumps all the data on screen (not readable) and then the same trimmed view of the df. I am not sure of what methods to override. Or maybe a separate method for this?
There was a problem hiding this comment.
Oh, I guess DataFrames use the :limit option of IOContext to control the omitting.
You can try this:
show(IOContext(stdout, :limit => false), df)
vs
show(df)
I think we can also utilize that option.
columns (JuliaStats#468) with tests added
src/timearray.jl
Outdated
| Base.show(io::IO, ta::TimeArray) = | ||
| print_time_array(io, ta, get(io, :limit, false), get(io, :limit, true)) | ||
| Base.show(io::IO, ::MIME"text/plain", ta::TimeArray) = | ||
| print_time_array(io, ta, false, !get(io, :limit, false)) |
There was a problem hiding this comment.
I checked the :limit in the show methods definition and added a new parameter in print_time_array to control the printing of all columns.
There was a problem hiding this comment.
It is working as follows:
- Showing a
TimeArrayin the REPL by just calling it by name (sayta) prints omitted columns message if theTimeArrayhas lots of columns. - Calling
@show taprints all columns and then the compact view. Similar toDataFramesbut the first output a little more ordered.
I had to modify some tests to pass the :limit option of IOContext
There was a problem hiding this comment.
I'm investigating why show(ta) and @show ta look different. 🤔
There was a problem hiding this comment.
ah, I figured it out, our implementation is correct.
@show invoking sprint with IOBuffer for rendering, so the return of displaysize(io) is different from displaysize(stdout).
Co-authored-by: Iblis Lin <iblis.dif01@nctu.edu.tw>
- Removed last newline - Removed individual show method
test/timearray.jl
Outdated
| @@ -480,7 +480,7 @@ end | |||
|
|
|||
| @testset "show methods don't throw errors" begin | |||
| io = IOBuffer() | |||
| let str = sprint(show, cl) | |||
| let str = sprint(summary, cl) | |||
| out = "500×1 TimeArray{Float64,1,Date,Array{Float64,1}} 2000-01-03 to 2001-12-31" | |||
There was a problem hiding this comment.
It seems that tests are failing in 1.6 because Array{Float64,1} is now shown as Vector{Float64} and Array{Float64,2} as Matrix{Float64}.
There was a problem hiding this comment.
Maybe in test/timearray.jl we can add a string to interpolate in the output depending on the value of VERSION. Something like:
dispvec = VERSION < v"1.6" ? "Array{Float64,1}" : "Vector{Float64}"Or maybe even typed:
dispvec(T) = VERSION < v"1.6" ? "Array{$(repr(T)),1}" : "Vector{$(repr(T))}"There was a problem hiding this comment.
Turns out that this TimeArray{Float64,1,Date,Array{Float64,1}} becomes TimeArray{Float64, 1, Date, Vector{Float64}} in 1.6.
|
Thanks for your contributions. 👍 |
|
Glad to help 😬 |
Hello, this is a proposal to fix #468. It prints page 1 of
TimeArrayand adds the omitted columns message. I would like some feedback on it.I have not rewritten the tests yet, but I'd gladfully do it.