Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to widen type if string has size 1 #26

Merged
merged 2 commits into from
Apr 9, 2022
Merged

Don't try to widen type if string has size 1 #26

merged 2 commits into from
Apr 9, 2022

Conversation

nickrobinson251
Copy link
Collaborator

@nickrobinson251 nickrobinson251 changed the title Don't widen type if string has size 1 Don't try to widen type if string has size 1 Apr 8, 2022
quinnj
quinnj approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickrobinson251!

@quinnj quinnj merged commit 0dcfd32 into JuliaStrings:main Apr 9, 2022
@nickrobinson251 nickrobinson251 deleted the npr/issue25 branch April 9, 2022 18:13
@nickrobinson251 nickrobinson251 mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible bug in inlinestrings for length-1 strings
2 participants
@nickrobinson251 @quinnj