Support constructing from bytes buffer alone #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was there a reason not to support this and instead require a user to give
pos
andlen
arguments explicitly?I don't particularly have a use-case beyond having expected this to work having it tried it when developing locally...
Since someone can write
I thought it might make sense to be able to write
I think
length(buf)
is probably the correct default, e.g. to get(rather than e.g. just consuming as much of the buffer as would fit in the requested type)