fix ambiguous getindex; closes #61 (#62)

JuliaStrings · Jun 22, 2022 · a84e05a · a84e05a
1 parent 94a24a8
commit a84e05a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/LaTeXStrings.jl b/src/LaTeXStrings.jl
@@ -118,6 +118,7 @@ Base.getindex(s::LaTeXString, i::Int) = getindex(s.s, i) # for method ambig in J
 Base.getindex(s::LaTeXString, i::UnitRange{Int}) = getindex(s.s, i)
 Base.getindex(s::LaTeXString, i::UnitRange{<:Integer}) = getindex(s.s, i)
 Base.getindex(s::LaTeXString, i::AbstractVector{<:Integer}) = getindex(s.s, i)
+Base.getindex(s::LaTeXString, i::AbstractVector{Bool}) = getindex(s.s, i) # for method ambiguity
 Base.codeunit(s::LaTeXString, i::Integer) = codeunit(s.s, i)
 Base.codeunit(s::LaTeXString) = codeunit(s.s)
 Base.ncodeunits(s::LaTeXString) = ncodeunits(s.s)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -57,6 +57,21 @@ end
     )
 end
 
+@testset "indexing" begin
+    tst1 = L"an equation: $\alpha^2$"
+    tst1s = String(tst1)
+
+    @test tst1[5] == tst1s[5]
+    @test tst1[15] == tst1s[15]
+
+    idx = [5, 10, 15]
+    @test tst1[idx] == tst1s[idx]
+
+    # issue #61
+    idx = rand(Bool, length(tst1))
+    @test_throws ArgumentError tst1[idx]
+end
+
 using Documenter
 DocMeta.setdocmeta!(LaTeXStrings, :DocTestSetup, :(using LaTeXStrings); recursive=true)
 doctest(LaTeXStrings; manual = false)