Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement readavailable and bytesavailable #53

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

nalimilan
Copy link
Member

These are used notably by the fallback write(::IO, ::IO) implementation. Their absence makes CSV.File(open(f, enc"...")) fail with recent CSV.jl versions.

Fixes JuliaData/CSV.jl#1022.

These are used notably by the fallback `write(::IO, ::IO)` implementation.
Their absence makes `CSV.File(open(f, enc"..."))` fail with recent CSV.jl versions.
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #53 (e0420b5) into master (2085821) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   91.70%   91.98%   +0.28%     
==========================================
  Files           2        2              
  Lines         229      237       +8     
==========================================
+ Hits          210      218       +8     
  Misses         19       19              
Impacted Files Coverage Δ
src/StringEncodings.jl 92.10% <100.00%> (+0.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when reading csv in non UTF-8 encoding
2 participants