Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LDFLAGS when building libutf8proc.dylib #125

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Use LDFLAGS when building libutf8proc.dylib #125

merged 1 commit into from
Apr 18, 2018

Conversation

ryandesign
Copy link
Contributor

This PR makes the Makefile use $(LDFLAGS) when building libutf8proc.dylib, just as it already does when building libutf8proc.so.

nalimilan
nalimilan approved these changes Apr 18, 2018
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ararslan
ararslan approved these changes Apr 18, 2018
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, how we have this set up as a separate target for macOS is a little weird, but as long as we have it set up this way, this change seems right. Thanks!

@ararslan ararslan merged commit 6a20831 into JuliaStrings:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryandesign @nalimilan @ararslan