Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate and install a pkg-config file. #142

Merged
merged 5 commits into from Nov 1, 2018
Merged

Generate and install a pkg-config file. #142

merged 5 commits into from Nov 1, 2018

Conversation

tlsa
Copy link
Contributor

@tlsa tlsa commented Aug 23, 2018

This adds a pkg-config file for libutf8proc.

Fixes issue #105.

@tlsa
Generate and install a pkg-config file.
2818dae
@tlsa
Use Makefile libdir and includedir for pkg-config.
a4cd6dc 
This splits the prefix out from these variables, so that
the same variables can be used to construct the pkg-config
file.
@tlsa
Update the manifest for installation of pkg-config file.
67cb57d
@tlsa
Copy link
Contributor Author

tlsa commented Sep 12, 2018

@stevengj Does this look reasonable?

stevengj
stevengj reviewed Sep 12, 2018
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@tlsa
Revert "Use Makefile libdir and includedir for pkg-config."
9a898c5 
This reverts commit a4cd6dc.
@tlsa
Use Makefile libdir and includedir for pkg-config.
53fb330 
This splits the prefix out from these variables, so that
the same variables can be used to construct the pkg-config
file.
@tlsa
Copy link
Contributor Author

tlsa commented Sep 13, 2018

@stevengj Oh, good point. I still think it's worth ensuring the pkgconfig files stay in sync though, so I've reverted the previous change, and done it like this 53fb330 instead.

nalimilan
nalimilan reviewed Sep 14, 2018
View reviewed changes
Makefile Show resolved Hide resolved
@tlsa
Copy link
Contributor Author

tlsa commented Sep 24, 2018

@stevengj Is this OK now?

@stevengj
Copy link
Member

stevengj commented Nov 1, 2018

LGTM.

@stevengj stevengj merged commit 5dcd382 into JuliaStrings:master Nov 1, 2018
@tlsa tlsa deleted the tlsa/pkgconfig-file branch March 28, 2019 19:52
@stevengj stevengj mentioned this pull request Mar 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan left review comments

@stevengj stevengj stevengj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tlsa @stevengj @nalimilan