Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added rule for 1^x == 1 in POW_RULES #469

Merged
merged 3 commits into from
Oct 4, 2022
Merged

added rule for 1^x == 1 in POW_RULES #469

merged 3 commits into from
Oct 4, 2022

Conversation

pagnani
Copy link
Contributor

@pagnani pagnani commented Sep 5, 2022

  • Brought this up on discourse, and relative to issue 437.
  • It basically introduces a new simplification rule that sets, as for the title, the rule 1^x == 1, which should be ok for all x.
  • Mathematica enforces it by default, and it seems a good idea to have it here.

@YingboMa
Copy link
Member

YingboMa commented Sep 7, 2022

The failure is real.

@pagnani
Copy link
Contributor Author

pagnani commented Sep 8, 2022

Yeah, there was a typo in the test. Test now pass locally ...

@pagnani
Copy link
Contributor Author

pagnani commented Oct 4, 2022

Is there anything more to do here?

@shashi shashi merged commit a42082a into JuliaSymbolics:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pagnani @YingboMa @ChrisRackauckas @shashi