Fix: Resolve head ambiguity and prevent UndefVarError and precompilation failure
#1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenszhu
force-pushed
the
b/modelingtoolkit-precompile-head
branch
from
c743def
to
0d68316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an error encountered due to the ambiguity of the
headfunction. Both the DataStructures and TermInterface packages exporthead, leading to a warning, ultimately anUndefVarErrorwithin the Symbolics module and the precompilation failure in ModelingToolkit integration test CI https://github.com/JuliaSymbolics/SymbolicUtils.jl/actions/runs/9640298551/job/26583838382?pr=615#step:6:8987 in PR JuliaSymbolics/SymbolicUtils.jl#615.To resolve this, an instance of
head(O)within Symbolics.jl has been replaced withTermInterface.head(O).