Reduce dependencies and compilation #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
commented
Jun 26, 2024
| abstract type Operator <: Function end | ||
| abstract type Operator end |
There was a problem hiding this comment.
@YingboMa or @shashi do either of you know why this causes things to start requiring nameof in show methods? I think I may move this abstract type to SymbolicUtils so it can be handled there, but I don't quite know where it's looking for whether something is truly a function or not and why that makes a difference.
YingboMa
reviewed
Jun 27, 2024
| @@ -45,6 +45,7 @@ end | |||
| (D::Differential)(x::Union{Num, Arr}) = wrap(D(unwrap(x))) | |||
| (D::Differential)(x::Complex{Num}) = wrap(ComplexTerm{Real}(D(unwrap(real(x))), D(unwrap(imag(x))))) | |||
| SymbolicUtils.promote_symtype(::Differential, T) = T | |||
| SymbolicUtils.isbinop(f::Differential) = false | |||
There was a problem hiding this comment.
What about all the other operators? This is a breaking change.
There was a problem hiding this comment.
Just in printing, and the follow up PR fixes the printing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.