Error bars for BarChart #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykelk
reviewed
Jan 22, 2019
src/PGFPlots.jl
Outdated
| println(o, "table [") | ||
| println(o, "x error plus=ex+, x error minus=ex-, y error plus=ey+, y error minus=ey-") | ||
| println(o, "] {") | ||
| println(o, "x y ex+ ex- ey+ ey-") | ||
| x = vcat(p.data, p.errorBars.data) |
There was a problem hiding this comment.
Why did this line need to be moved? It looks like it came before the table originally, right?
There was a problem hiding this comment.
Sorry it was unnecessary, I moved it while I was prototyping and forgot to move it back. I will revert this change
|
Cool. You can merge once the travis finishes. Please also tag a release for attobot. Thanks! |
|
I don't have the rights to merge or tag |
|
You should have access now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the way I implemented it might be clumsy, there is a lot of repeated code with the implementation for the
Lineartype. Any suggestions are welcome.