Address several issues discovered in testing #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Sep 7, 2021
This should be slightly more robust in that we have explicit type mappings. We also add a simple promote mechanism to use the native type if unspecified in the Stream call.
sjkelly
force-pushed
the
sjk/highlevel3
branch
from
2a9a7b0
to
52023cb
Compare
|
I put back the old assertion, with an additional comment in the warning. The main issue can be avoided by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses Large StreamBuffer requests do not block until fulfilled #17 by removing the assert in
read, and allowing fewer samples as allowed by the semantics of Julia'sreadSimplifies the SoapySDR <-> Julia Type pathway. We eliminate the
StreamFormatcontainer, and just use a few helper functions to keep this abstraction from leaking through the high level API.Constructing a new
Streamwill use the native device format by default (we have multiple dispatch, so we should use it.). It is also now aware of the MTU, thus giving a simplifiedreadfunction without a specified length.I think this should encapsulate the API changes to address the issues discovered in testing (thanks @mbaz !) I'll need to add some more docs here to full clarify how the
Streaminterface works, mainly regardingactivate!/deactivate!functions if not using continuous processing. (I'm investigating if we have IO interface semantics in Base for this already)re: #17 #13 #12 #8