Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piracy: Add kwarg treat_as_own #140

Merged
merged 6 commits into from
Jun 24, 2023
Merged

Piracy: Add kwarg treat_as_own #140

merged 6 commits into from
Jun 24, 2023

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Jun 16, 2023 •
edited
Loading

Resolves #138, resolves #96.

@codecov
Copy link

codecov bot commented Jun 16, 2023 •
edited
Loading

Codecov Report

Merging #140 (1114993) into master (dd1d392) will not change coverage.
The diff coverage is 92.85%.

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   76.37%   76.37%           
=======================================
  Files          11       11           
  Lines         711      711           
=======================================
  Hits          543      543           
  Misses        168      168
Flag Coverage Δ
unittests 76.37% <92.85%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/piracy.jl 91.04% <92.85%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgoettgens lgoettgens marked this pull request as draft June 19, 2023 10:13
@lgoettgens lgoettgens mentioned this pull request Jun 19, 2023
Closed
@lgoettgens
Copy link
Collaborator Author

This now contains two treat_as_own kwargs, one for types and one for functions (cf. #138 (comment)).

This is still a draft as I am unhappy with the names treat_as_own_type and treat_as_own_func.
Maybe @devmotion or @fingolfin or someone else has an idea?

@lgoettgens lgoettgens mentioned this pull request Jun 21, 2023
Merged
fingolfin
fingolfin reviewed Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this now needs conflict resolution.

src/piracy.jl Outdated Show resolved Hide resolved
src/piracy.jl Outdated Show resolved Hide resolved
src/piracy.jl Outdated Show resolved Hide resolved
@lgoettgens
Address comments
9e0a05b 
* Merge both kwargs into one
* Remove type constraint to allow arbitrary containers
* Remove default value for non user facing functions
@lgoettgens lgoettgens marked this pull request as ready for review June 24, 2023 15:42
@fingolfin
Copy link
Collaborator

Oops another conflict 😞

@lgoettgens
Copy link
Collaborator Author

Thanks for resolving!

@fingolfin fingolfin merged commit 175e78f into JuliaTesting:master Jun 24, 2023
17 checks passed
@lgoettgens lgoettgens deleted the lg/piracy branch June 25, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypePiracy: treat foreign type as own type Allow type piracy from superpackage?
2 participants
@lgoettgens @fingolfin