Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Project formatting on Julia <1.7 if there are weakdeps #206

Closed
wants to merge 1 commit into from

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Oct 12, 2023

Brutal fix for #208. If the Julia version is below 1.7 and the Project.toml contains weakdeps or extensions, its formatting test will now return true by default.
This only affects people who write package extensions, and my assumption is that those people test on 1.9 and above anyway.

See also JuliaLang/Pkg.jl#3481

Ping @adrhill

closes #209, closes #210

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #206 (d2d62f8) into master (19a5588) will increase coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head d2d62f8 differs from pull request most recent head 801677d. Consider uploading reports for the commit 801677d to get more accurate results

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   76.80%   76.86%   +0.06%     
==========================================
  Files          11       11              
  Lines         763      765       +2     
==========================================
+ Hits          586      588       +2     
  Misses        177      177              
Flag Coverage Δ
unittests 76.86% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/project_toml_formatting.jl 86.48% <100.00%> (+0.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fingolfin fingolfin linked an issue Oct 24, 2023 that may be closed by this pull request
@gdalle gdalle deleted the project_extensions_16 branch October 26, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project.toml formatting test not sensible in julia pre-1.7
2 participants