-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Plots.jl plots? #26
Comments
@Evizero did you have a chance to take a look at this? |
ReferenceTests uses I think it would be without much difficults to change to |
Thank you @johnnychen94 , I am most interested in comparin image plots without relying on Gtk. A preview on the terminal would be perfect. Do you think it would be possible to add a comparison for Plots.jl plots that compares the images generated directly on the terminal as opposed to launching a Gtk windows for visual comparison? Gtk.jl is quite a dependency. My tests take a while to start just building Gtk. |
One doesn't need to worry about rendering, that is orthogonal to comparison. All one needs is a way to convert a plot to a The following isn't great,
creates the file Demo changedAfter running the above:
Output Remember what I said above, the rendering is seperate fron the comparasion. |
I think what @juliohm wants is to show ACTUAL and REFERENCE through
An example from |
Thank you all. The idea is to have the comparison as usual without preview, and then perhaps visualize the images in the terminal when the comparison fails. Is it true that ImageInTerminal.jl can only show thumbnail versions of the images? My main concern with VisualRegressionTests.jl is the Gtk.jl dependency. |
This is what ReferenceTest.jl does
Yes, the DPI is fixed by your font size... Terminals do not have the intrinsic ability to display anothing but unicode+colors. |
First off, thank you for the package :)
I am wondering if there are handlers for plots implemented? I am considering this package instead of VisualRegressionTests.jl because it is well-maintained, and seems more general as well. Could you please elaborate on the dependencies needed for storing plots as images? Can we just use the image handler when we get a plot object?
The text was updated successfully, but these errors were encountered: