Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional metadata fields #102

Closed
wants to merge 4 commits into from

Conversation

zgornel
Copy link

@zgornel zgornel commented Oct 1, 2018

This PR:

  • Adds additional metadata fields to documents: id (document identifier), publisher, edition_year, published_year, documenttype and associated functions for mutating, obtaining the fields and tests.
  • Bugfixes: Imports Base.show, Base.names and removes outer 'using DataFrames'

The new fields might prove useful if working with large sets of documents (i.e. publications, books) where these fields can provide helpful in creating subsets of documents based on their values. The changes are innocuous by themselves as backward compatibility with existing code should be ensured.

PS. changes from commit 7f5fc87 were discarded when rebasing on the latest master

@zgornel
Copy link
Author

zgornel commented Nov 21, 2018

Closing this pull for lack of feedback.

@zgornel zgornel closed this Nov 21, 2018
@zgornel zgornel deleted the additional_metadata branch November 27, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant