Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18 interface mlj #21

Merged
merged 6 commits into from
Jul 6, 2023
Merged

18 interface mlj #21

merged 6 commits into from
Jul 6, 2023

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented Nov 29, 2022

  • add GH workflows back in
  • re-render docs

@pat-alt pat-alt linked an issue Nov 29, 2022 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #21 (e15d3eb) into main (ce25e33) will decrease coverage by 7.26%.
The diff coverage is 81.48%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   99.59%   92.33%   -7.26%     
==========================================
  Files           6       10       +4     
  Lines         244      261      +17     
==========================================
- Hits          243      241       -2     
- Misses          1       20      +19     
Impacted Files Coverage Δ
src/LaplaceRedux.jl 100.00% <ø> (ø)
src/MLJLaplaceRedux/MLJLaplaceRedux.jl 0.00% <0.00%> (ø)
src/baselaplace.jl 98.09% <96.96%> (-1.91%) ⬇️
src/laplace.jl 100.00% <100.00%> (+1.12%) ⬆️
src/plotting.jl 91.11% <100.00%> (-8.89%) ⬇️
src/utils.jl 90.00% <0.00%> (-10.00%) ⬇️
src/curvature/Curvature.jl 100.00% <0.00%> (ø)
src/data/Data.jl 100.00% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pat-alt pat-alt mentioned this pull request Jan 27, 2023
severinbratus pushed a commit that referenced this pull request Jul 5, 2023
Subnetwork and Last Layer Laplace Models
@codecov-commenter
Copy link

Codecov Report

Merging #21 (82971bf) into main (98d82ce) will increase coverage by 0.04%.
The diff coverage is 94.11%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   96.74%   96.78%   +0.04%     
==========================================
  Files          10       10              
  Lines         614      622       +8     
==========================================
+ Hits          594      602       +8     
  Misses         20       20              
Impacted Files Coverage Δ
src/LaplaceRedux.jl 100.00% <ø> (ø)
src/mlj_flux.jl 95.86% <87.50%> (ø)
src/baselaplace.jl 89.58% <89.83%> (-0.42%) ⬇️
src/curvature/functions.jl 97.94% <100.00%> (ø)
src/data/functions.jl 100.00% <100.00%> (ø)
src/laplace.jl 100.00% <100.00%> (+4.08%) ⬆️
src/plotting.jl 97.77% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pat-alt
Copy link
Member Author

pat-alt commented Jul 6, 2023

On second thoughts, it seems to make more sense to have a separate class that subtypes <:MLJLufxDeterministic

@pat-alt pat-alt mentioned this pull request Jul 6, 2023
@pat-alt pat-alt merged commit 5f41f2e into main Jul 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface MLJ
2 participants