Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 😠 for mean ∘ skipmissing #35

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

LilithHafner
Copy link
Contributor

This comes from a recent gripe on slack. Somebody wants a shorter name for mean ∘ skipmissing and I figure this is a great opportunity to expand the user-base of this package.

While I'll admit :angry; is not ideal (:mean: would be better, were it a thing), I think this face looks a little mean: 😠, and I think the slight deviation is also appropriate as it reflects the semantic variation from traditional mean. If we used :mean:, folks might mistakenly think we were aliasing to Julia's mean.

Also, the motivation for this addition is a user's anger at not having a brief way of expressing mean ∘ skipmissing.

@Moelf
Copy link

Moelf commented Nov 6, 2023

we need @😠 for making everything skipmissing, just like @.

@theogf
Copy link
Member

theogf commented Nov 6, 2023

Sounds great could you just add it to the func_to_emojis Dict in WatchJuliaBurn.jl such that it also gets rendered in the README?

Just add a new line as:

:(mean ∘ skipmissing) = (:(😠),)

@LilithHafner
Copy link
Contributor Author

Lovely! I didn't know that that dict could handle non-symbols on the LHS (e.g. sorting for the README & for equality in emojify).

@theogf
Copy link
Member

theogf commented Nov 6, 2023

Oh you're right... It might need some more hacking around. LGTM and I'll add some shady fix

@theogf theogf merged commit a9e6d52 into JuliaWTF:master Nov 6, 2023
theogf added a commit that referenced this pull request Dec 15, 2023
* Fix CI

* Add CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants