Skip to content

Commit

Permalink
Fix apps test
Browse files Browse the repository at this point in the history
Also get rid of the timestamps from the App type. They have time zone information (now,
they didn't a few days ago when I wrote the code for the first time),
which we currently don't handle. I played with TimeZones.jl, but it currently can't
parse the GitHub time stamp. For now, just delete those fields and revisit that
once TimeZones.jl has been updated to handle this better.
  • Loading branch information
Keno committed Aug 10, 2017
1 parent 98b9336 commit 7245c56
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions src/apps/apps.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ type App <: GitHubType
description::Nullable{String}
external_url::Nullable{String}
html_url::Nullable{String}
created_at::Nullable{Dates.DateTime}
updated_at::Nullable{Dates.DateTime}
end

namefield(a::App) = a.id
Expand Down
4 changes: 2 additions & 2 deletions test/read_only_api_tests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,6 @@ end
end

@testset "Apps" begin
@test get(app(4123).name) == "femtocleaner"
@test get(app("femtocleaner").name) == "femtocleaner"
@test get(app(4123; auth=auth).name) == "femtocleaner"
@test get(app("femtocleaner"; auth=auth).name) == "femtocleaner"
end

0 comments on commit 7245c56

Please sign in to comment.