Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load HDF5 on travis without sudo and hide 0.4 / show 0.6 pkg badge #69

Merged
merged 5 commits into from
Jul 28, 2017
Merged

Load HDF5 on travis without sudo and hide 0.4 / show 0.6 pkg badge #69

merged 5 commits into from
Jul 28, 2017

Conversation

KristofferC
Copy link
Collaborator

@KristofferC KristofferC commented Jul 22, 2017 •
edited
Loading

Also use String instead of UTF8String now when 0.4 support is dropped. Could rename GitHubString to String but not sure if that is wanted.

@KristofferC KristofferC mentioned this pull request Jul 22, 2017
Merged
@KristofferC
Copy link
Collaborator Author

This should be fairly uncontroversial?

@jrevels
Copy link
Member

jrevels commented Jul 24, 2017

Could rename GitHubString to String but not sure if that is wanted.

That would be great, thanks (sorry for the late reply, I don't keep up with GitHub.jl too frequently).

@KristofferC
Copy link
Collaborator Author

Done

@KristofferC
Copy link
Collaborator Author

I sneaked in a @testset commit here as well. Hope that is ok.

@KristofferC
Copy link
Collaborator Author

Anything left to do here?

@jrevels jrevels merged commit 2d21ea9 into JuliaWeb:master Jul 28, 2017
@jrevels
Copy link
Member

jrevels commented Jul 28, 2017

Thanks again!

@KristofferC KristofferC deleted the kc/hdf5 branch July 28, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KristofferC @jrevels