Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "When monitoring idle connections, only call eof on tcp socket" #914

Merged
merged 1 commit into from Aug 26, 2022

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Aug 26, 2022

Reverts #912

The problem here is that when we go to reuse connections later, the ssl layer hasn't had time (or been told by monitor_idle_connections) to process encrypted data and potential close notify records. This can be bad if you, for example, do a bunch of simultaneous requests which build up a bunch of MbedTLS.SSLContext connections in the connection pool, then go to try and do a request later and all the connections are actually closed, even though they haven't been properly closed at the ssl layer.

@quinnj quinnj merged commit f1e4591 into master Aug 26, 2022
@quinnj quinnj deleted the revert-912-jq/cleanupidle branch August 26, 2022 13:55
@vtjnash
Copy link
Member

vtjnash commented Aug 29, 2022

Yeah, I don't think that PR was right. Violating the abstraction of the underlying socket by examining its internal state is likely to lead to problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants