When monitoring idle connections, only call eof on tcp socket #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a heavy cloud storage workflow, I encountered the following error: ``` AssertionError: ctx.bytesavailable > 0 || !(ctx.isreadable) ``` with traces back to calling `eof(::SSLContext)` from `monitor_idle_connection`. As the workflow was highly concurrent, I believe the error was just a data race between an old async `monitor_idle_connection` task calling `eof` -> `wait_for_decrypted_data`, but when returning from `wait_for_decrypted_data` due to a new connection being reused in HTTP.jl, the `handshake` was redone, which resulted in the `AssertionError` shown above. The proposal here is that when monitoring idle connections, we only call `eof` on the underlying TCPSocket, since we're really only concerned with knowing whether the core socket gets additional data, encrypted or not, when we don't expect it.
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
==========================================
+ Coverage 80.13% 80.26% +0.12%
==========================================
Files 36 36
Lines 2915 2918 +3
==========================================
+ Hits 2336 2342 +6
+ Misses 579 576 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
quinnj
added a commit
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a heavy cloud storage workflow, I encountered the following error:
with traces back to calling
eof(::SSLContext)frommonitor_idle_connection.As the workflow was highly concurrent, I believe the error was just a data race
between an old async
monitor_idle_connectiontask callingeof->wait_for_decrypted_data,but when returning from
wait_for_decrypted_datadue to a new connection being reused in HTTP.jl,the
handshakewas redone, which resulted in theAssertionErrorshown above.The proposal here is that when monitoring idle connections, we only call
eofon the underlyingTCPSocket, since we're really only concerned with knowing whether the core socket gets additional
data, encrypted or not, when we don't expect it.