Couple of fixes for various things and making cookie tracking on by default #560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just a few small fixes. The biggest change is making
cookies=true
by default, which means we'll track cookies for users automatically. There was at least one case recently where a user was frustrated because it didn't seem like HTTP.jl could do "session management" like they were used to in pythonrequests
. We've made a couple of changes recently that make HTTP.jl act more and more like a friendlier client, so I think this makes sense.cc-ing a couple people in case they have opinions on tracking cookies by default: @staticfloat , @StefanKarpinski , @oxinabox , @mattBrzezinski