Accept abstract strings, but concisely #639
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
approved these changes
Dec 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
+ Coverage 75.59% 77.47% +1.88%
==========================================
Files 36 36
Lines 2151 2309 +158
==========================================
+ Hits 1626 1789 +163
+ Misses 525 520 -5
Continue to review full report at Codecov.
|
quinnj
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Funny story, that last PR I submitted could have been better. This is it, but better :)