Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set userinfo from http(s)_proxy to proxy-auth #640

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

p1scescom
Copy link
Contributor

@p1scescom p1scescom commented Dec 8, 2020

add a process to set proxy-authorization basic like src/BasicAuthRequest.jl if proxy-url has userinfo
I confirmed that it works in my proxy environment.

add a process to set proxy-authorization basic like src/BasicAuthRequest.jl if proxy-url has userinfo
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@quinnj quinnj merged commit a91ec98 into JuliaWeb:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants