Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid allocations in ascii_lc_isequal #725

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Avoid allocations in ascii_lc_isequal #725

merged 1 commit into from
Jun 20, 2021

Commits on Jun 18, 2021

  1. Avoid allocations in ascii_lc_isequal

    Fixes #724. Maybe in a perfect world, the compiler would be able to "see
    through" the calls to `Iterators.Stateful` and `zip` iterating through
    them to avoid allocating `Stateful` at all, but this also just feels
    like a case of a very low-level function trying to use high-level
    constructs. The proposed code here is an order of magnitude faster (~10x
    in the few cases I tested), avoids all allocations, and IMO, is simpler
    (I'm guessing most users don't immediately understand what
    `Iterators.Stateful` is for).
    quinnj committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    9692998 View commit details
    Browse the repository at this point in the history