Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uint16 #845

Merged
merged 1 commit into from Jun 11, 2022
Merged

Use uint16 #845

merged 1 commit into from Jun 11, 2022

Conversation

rikhuijzer
Copy link
Contributor

@rikhuijzer rikhuijzer commented Jun 11, 2022

FrameFlags is used only inside the WebSockets module while extending Base.UIn16 is global. This PR may avoid some unnecessary method invalidations.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2022

Codecov Report

Merging #845 (a16b3e3) into master (d619890) will decrease coverage by 0.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   77.82%   77.32%   -0.50%     
==========================================
  Files          35       35              
  Lines        2755     2756       +1     
==========================================
- Hits         2144     2131      -13     
- Misses        611      625      +14     
Impacted Files Coverage Δ
src/WebSockets.jl 55.71% <100.00%> (+0.16%) ⬆️
src/HTTP.jl 67.79% <0.00%> (-15.26%) ⬇️
src/RetryRequest.jl 60.86% <0.00%> (-4.35%) ⬇️
src/Messages.jl 87.24% <0.00%> (-1.35%) ⬇️
src/cookiejar.jl 77.01% <0.00%> (-0.58%) ⬇️
src/ConnectionPool.jl 87.43% <0.00%> (-0.51%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fredrikekre fredrikekre merged commit 64c980e into JuliaWeb:master Jun 11, 2022
@rikhuijzer rikhuijzer deleted the rh/uint16 branch June 12, 2022 13:26
@quinnj
Copy link
Member

quinnj commented Jun 13, 2022

Thanks @rikhuijzer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants