Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HTTP.jl exception types more consistent #846

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Make HTTP.jl exception types more consistent #846

merged 2 commits into from
Jun 14, 2022

Commits on Jun 14, 2022

  1. Make HTTP.jl exception types more consistent 

    Closed #792. In particular, calling `HTTP.request` will result
in one of four possible exceptions:
  * `HTTP.ConnectError`: something went wrong trying to make a connection to the remote
  * `HTTP.RequestError`: something went wrong sending/receiving request/response
  * `HTTP.StatusError`: a 4XX or 5XX response status code was received and status_exception=true
  * `HTTP.TimeoutError`: the request timed out waiting for a response (if `readtimeout` != 0)

Looking over open issues and how downstream repos use HTTP.jl, I found it would be helpful if
HTTP.jl indeed had more consistent exception types in place for 1.0 that packages could rely on.
    @quinnj
    quinnj committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    4b14852 View commit details
    Browse the repository at this point in the history

  2. rename file

    @quinnj
    quinnj committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    a2f26df View commit details
    Browse the repository at this point in the history