Cleanup OpenSSL implementation #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #937. There's a corresponding [OpenSSL PR](JuliaWeb/OpenSSL.jl#5) that fixes the actual verification bug, but I noticed some cleanup needed along the way. Notably: * Fix issue if you were using OpenSSL w/ a proxy, we would try to do the proxy upgrade still using MbedTLS * Create a default global `OpenSSL.SSLContext` that gets reused for every individual connection (as intended by the library)
gustafsson
added a commit
to gustafsson/HTTP.jl
that referenced
this pull request
Oct 18, 2022
The sockettype for ConnectionPool.sslupgrade should depend on target_url rather than url. These are not necessarily on the same schema. I.e if "https_proxy=http://..."
quinnj
pushed a commit
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #937.
There's a corresponding OpenSSL PR that fixes the actual verification bug, but I noticed some cleanup needed along the way.
Notably:
OpenSSL.SSLContextthat gets reused for every individual connection (as intended by the library)