-
Notifications
You must be signed in to change notification settings - Fork 37
Update http-parser version #27
Conversation
Changes Unknown when pulling 9700263 on nosub into * on master*. |
Why pull whole repo when versioned releases exist? |
Isn't that what this does, checkout a versioned release? |
I meant tarball. BTW, is there problem with windows build? Why downloaded binaries are needed? |
Yeah tarball would be fine, especially since it is simpler. I just really didn't like the git submodule. On Windows we don't assume there is a compiler (there usually isn't), so we need to provide a binary. We also in general assume the same thing for OSX in many packages, although not here. |
@tkelman if you ever get bored, here is a project that'd be good to give the WinRPM treatment |
copy-pasting this from a sublime window, from notes I took with @yeesian yesterday - we did libgeos in like an hour
I'll be cleaning this up and adding it to the winrpm readme soon. |
I say, we bump to 2.5 and build C library through BinDeps, at lease for Unix platforms. This will prevent version mismatch, like #32. As for Windows, we need to build binary anyway. |
WIP as I need to cross-compile and upload new Windows binaries