Add linux sll support #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inst it so clippy does not complain about overlaps
…ors, tests and utilities
|
Wow thanks for that PR. I will have a deep look into it tomorrow, but so far it looks incredible. |
JulianSchmid
approved these changes
May 2, 2024
JulianSchmid
reviewed
May 2, 2024
|
I will fix the errors that my no-std fix introduced in the evening. |
Ok perfect, sounds good! When I finish other work I have I'll to look into to finish implementing the rest. |
|
That's an amazing addition. Thanks for the work @RabadanDotDev and @JulianSchmid for reviewing ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work mentioned in #97. I implemented the part of the public interface I was most interested in (SlicedPacket::from_linux_sll) and all the additions/extensions to the rest of the code it needed. There are some parts missing, but if you are interested in merging, I can work on them when I get the time.
Specifically, some points missing are: