Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action does not Label PRs #88

Closed
ChrisOwen101 opened this issue May 26, 2021 · 20 comments
Closed

Github Action does not Label PRs #88

ChrisOwen101 opened this issue May 26, 2021 · 20 comments

Comments

@ChrisOwen101
Copy link

ChrisOwen101 commented May 26, 2021

Hi, just wondering if this project is still supported as I'm struggling to get it to work

As you can see, I'd expect my PR to be tagged with the Improvement label.

Do you have any advice?

@ChrisOwen101
Copy link
Author

@JulienKode

@JulienKode
Copy link
Owner

Thanks for submitting this issue,

Sorry that you have some issue with it

Can you try the following version please ?

name: "team-labeller"
on:
  pull_request:

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
    - uses: JulienKode/team-labeler-action@v0.1.0
      with:
        repo-token: "${{ secrets.GITHUB_TOKEN }}"

@JulienKode
Copy link
Owner

I'll check on my side to reproduce this issue @ChrisOwen101

@ChrisOwen101
Copy link
Author

Thanks @JulienKode

You can find a run of the Github Action here with the code you've supplied above.

https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1/actions/runs/902392771

I can confirm that it is currently not working.

Happy to do whatever else you need to help fix this 😊

@JulienKode
Copy link
Owner

Thanks for your feedback @ChrisOwen101

I've try to create pull request on your repo, but it seems GitHub actions does not run when I do a pull request

I've try to create a new repo with the minimal setup needed for the team labeller action
https://github.com/JulienKode/team-labeler-action-test

I'll continue to investigate on this issue

@ChrisOwen101
Copy link
Author

@JulienKode - You can manually run the code by going here

https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1/actions/workflows/team-labeler.yml

And clicking on "Run Workflow"

image

@JulienKode
Copy link
Owner

Seems github does not suggest it to me

Screenshot 2021-06-10 at 08 17 20

@ChrisOwen101
Copy link
Author

@JulienKode I've invited you to have Maintain access for the repo - you should be able to run it now :)

@JulienKode
Copy link
Owner

Thanks @ChrisOwen101

@JulienKode
Copy link
Owner

JulienKode commented Jun 11, 2021

@JulienKode
Copy link
Owner

@ChrisOwen101

when you go to:
https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1/settings/actions

Did you have the following config ?
Screenshot 2021-06-11 at 22 30 33

@ChrisOwen101
Copy link
Author

@JulienKode

Yep, we've got that Setting on by default.

@JulienKode
Copy link
Owner

I've continue to take a look at this issue:

I've clone the repo on my side and push the repo to a repository that I own: JulienKode/JavaScript-Core-1-Coursework-Week1-test#1

Then I've just create this pull request

The action run well and I have the label with the exact same code and repository that you have setup

So you did everything good, I've think the issue is related to the config or right for the actions on the repository

If you want we can setup a call to take a look at the config ?

@dunklesToast
Copy link

dunklesToast commented Aug 4, 2021

I had the same problem. Turns out, you need to create the labels manually before.
You can do that here: https://github.com/user|org/repo/issues/labels

@JulienKode
Copy link
Owner

Thanks for catching this @dunklesToast, it help a lot

I didn't had to create it for my personal GitHub, so I guess this is related to GitHub org ?

@dunklesToast
Copy link

Hmm good question. I did use it on an organisation. Let me try in a personal project. Also, Markdown messed up the URL, I fixed it.

@dunklesToast
Copy link

Okay weird. I tested it via the "raw" GitHub API. It worked in Organization and on private projects without creating the label first. I wonder why I had to create them while using this action.

@JulienKode
Copy link
Owner

@dunklesToast @ChrisOwen101 does this issue is solved now ? or you still experience it

@dunklesToast
Copy link

Seems to be resolved for me

@JulienKode
Copy link
Owner

Thanks for your feedback @dunklesToast

I close this issue

Feel free to re-open it if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants