Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Python version matrix for GHA #95

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Nov 22, 2023

No description provided.

@JulienPalard
Copy link
Owner

If I get it right, your change make github start 4 runners, each of them installs tox and run tox (each with one single Python version to test), instead of starting a single runner, installing tox once, and having tox test with the 4 different Python version?

@gliptak
Copy link
Contributor Author

gliptak commented Nov 22, 2023

yes, above is great summary

@JulienPalard
Copy link
Owner

yes, above is great summary

Is it any better? I feel like having to spawn a single runner is lighter than having to spawn three.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 23, 2023

I see more isolation the better in various testing setups ensuring that fails are quickly attributable. while there is overhead for the multiple spawns, overall runtime would be very similar

https://github.com/JulienPalard/Pipe/actions/runs/4378790944 1 min 50 sec
https://github.com/gliptak/Pipe/actions/runs/6962332242 59 sec

@JulienPalard
Copy link
Owner

Your solution has less lines than mine, which is nice too.

@JulienPalard JulienPalard merged commit 3b73d7e into JulienPalard:main Nov 23, 2023
4 checks passed
@JulienPalard
Copy link
Owner

Thanks!

@gliptak gliptak deleted the python1 branch November 23, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants