Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYPI release 0.2.17 is not really 0.2.17 #54

Closed
sbyx opened this issue Nov 2, 2020 · 3 comments
Closed

PYPI release 0.2.17 is not really 0.2.17 #54

sbyx opened this issue Nov 2, 2020 · 3 comments

Comments

@sbyx
Copy link

sbyx commented Nov 2, 2020

It seems that when I'm doing a pip3 install pyvlx I'm not getting the 0.2.17 release of pyvlx even though it tells me it is 0.2.17
I noticed e.g. that in the connection.py of pyvlx still has this line (which is causing me trouble):

ssl_handshake_timeout=5,

even though it is not there in the release commit for 0.2.17: https://github.com/Julius2342/pyvlx/blob/9397bbe741623769f4137714d08538ebd29d3ff0/pyvlx/connection.py

I guess this might be related to #53 and maybe also #52.
Home Assistant is affected as well by this.

@sbyx sbyx changed the title PYPI release in 0.2.17 is not really 0.2.16 PYPI release in 0.2.17 is not really 0.2.17 Nov 2, 2020
@sbyx sbyx changed the title PYPI release in 0.2.17 is not really 0.2.17 PYPI release 0.2.17 is not really 0.2.17 Nov 2, 2020
@Julius2342
Copy link
Owner

Bumped a new release. May I ask you to try out 0.2.18 ?

@sbyx
Copy link
Author

sbyx commented Nov 2, 2020

I can confirm at least the offending line with the ssl_handshake_timeout is gone now after upgrading to 0.2.18 release using pip. If you want me to do any more tests please let me know.

@sbyx sbyx closed this as completed Nov 2, 2020
@sbyx
Copy link
Author

sbyx commented Nov 2, 2020

Thanks a lot for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants