Added support for light and blade types #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julius2342
reviewed
Feb 17, 2020
There was a problem hiding this comment.
Thank you very much! Looks good, i only have minor comments.
May I ask you to add some tests for Lights too? It would be great to have 100% test coverage for you component. I don't have velux lights and if i change anything in a couple of years I want to make sure I don't break your setup :-)
|
I am trying to add tests for lights but I have to learn how to do it before. |
|
I just added tests for Light and Blade types. |
|
But it looks like they are failing :-/ |
|
After few commits, tests failed on file and line that I did not modify. |
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for blade openers and lights.