Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update light intensity #32

Merged
merged 15 commits into from
Mar 29, 2020
Merged

Update light intensity #32

merged 15 commits into from
Mar 29, 2020

Conversation

Dimitri23
Copy link
Contributor

The intensity property is not updated correctly.

@coveralls
Copy link

coveralls commented Mar 28, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 82.281% when pulling 9f95f0c on Dimitri23:master into 476a3a0 on Julius2342:master.

@Dimitri23
Update intensity property of a Ligth node
9f95f0c 
Update property also when receive a FrameNodeStatePositionChangedNotification
Julius2342
Julius2342 approved these changes Mar 29, 2020
View reviewed changes
Copy link
Owner

@Julius2342 Julius2342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Julius2342 Julius2342 merged commit 5a0c5b7 into Julius2342:master Mar 29, 2020
@Dimitri23
Copy link
Contributor Author

Dimitri23 commented Apr 11, 2020 •
edited
Loading

I see that 6 checks are marked as "passed".
Which one fails ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julius2342 Julius2342 Julius2342 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dimitri23 @coveralls @Julius2342