Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge_try #350

Merged
merged 184 commits into from Dec 12, 2023
Merged

Merge_try #350

merged 184 commits into from Dec 12, 2023

Conversation

pawlizio
Copy link
Collaborator

@pawlizio pawlizio commented Nov 23, 2023

  • Add support for Dual Roller Shutters with 3 different subtypes (upper, lower and dual)
  • Add velocity support for Covers and Windows
  • Add support to specify open / close position target position, so you can adjust to which position a cover is moving on open and close command.
  • Fix ON/OFF switches
  • Add pull status request during Heartbeat
  • Add support to get calculated position values during Cover or Blind movemen

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Attention: 213 lines in your changes are missing coverage. Please review.

Comparison is base (8abf076) 81.96% compared to head (b7089ec) 79.97%.
Report is 1 commits behind head on master.

Files Patch % Lines
pyvlx/opening_device.py 34.71% 79 Missing ⚠️
pyvlx/node_updater.py 10.76% 58 Missing ⚠️
pyvlx/heartbeat.py 33.33% 24 Missing ⚠️
pyvlx/klf200gateway.py 20.00% 12 Missing ⚠️
pyvlx/parameter.py 78.57% 12 Missing ⚠️
pyvlx/connection.py 25.00% 9 Missing ⚠️
pyvlx/pyvlx.py 38.46% 8 Missing ⚠️
pyvlx/const.py 71.42% 4 Missing ⚠️
pyvlx/lightening_device.py 60.00% 2 Missing ⚠️
pyvlx/on_off_switch.py 50.00% 2 Missing ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage   81.96%   79.97%   -1.99%     
==========================================
  Files          77       77              
  Lines        3387     3560     +173     
==========================================
+ Hits         2776     2847      +71     
- Misses        611      713     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julius2342
Copy link
Owner

@pawlizio : good morning :) Are we ready to merge this PR? What do you think?

Copy link
Collaborator Author

@pawlizio pawlizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Julius2342 Yes, we can merge. Are you going to create a new release afterwards?
The last one is from January 2022 and there are lot's of changes since then. I'm wondering how all the users get the latest features and bugfixes. I mean in my custom I'm directly redirecting to my github clone through adjustment of the manifest.json.

@Julius2342
Copy link
Owner

Yes, i will bump a version after merge. May I ask you to provide a bulletpoint list of major changes of this PR for the changelog?

@Julius2342 Julius2342 merged commit 46992b4 into Julius2342:master Dec 12, 2023
4 checks passed
@Julius2342
Copy link
Owner

Yay!

@pawlizio
Copy link
Collaborator Author

I added a list above.

@Julius2342
Copy link
Owner

I released 0.2.21 and uploaded to pypi ...

@pawlizio pawlizio deleted the merge_try branch December 21, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants