Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py, exclude 'test' #370

Merged
merged 1 commit into from Jan 8, 2024
Merged

Conversation

onkelbeh
Copy link
Contributor

@onkelbeh onkelbeh commented Jan 4, 2024

Otherwise:

* Messages for package dev-python/pyvlx-0.2.21:

 * The following unexpected files/directories were found top-level
 * in the site-packages directory:
 *
 *   /usr/lib/python3.11/site-packages/test
 *
 * This is most likely a bug in the build system.  More information
 * can be found in the Python Guide:
 * https://projects.gentoo.org/python/guide/qawarn.html#stray-top-level-files-in-site-packages
 * ERROR: dev-python/pyvlx-0.2.21::HomeAssistantRepository failed (install phase):
 *   Failing install because of stray top-level files in site-packages

I hope you don't mind I included your component for Home Assistant Gentoo Overlay. I do not use this component myself. But, during compilation test, the installation test script threw an error, because setup.py tries to install a package called tests at top level.

My change only adds a generic exclusion to find_packages().

Otherwise:

```
* Messages for package dev-python/pyvlx-0.2.21:

 * The following unexpected files/directories were found top-level
 * in the site-packages directory:
 *
 *   /usr/lib/python3.11/site-packages/test
 *
 * This is most likely a bug in the build system.  More information
 * can be found in the Python Guide:
 * https://projects.gentoo.org/python/guide/qawarn.html#stray-top-level-files-in-site-packages
 * ERROR: dev-python/pyvlx-0.2.21::HomeAssistantRepository failed (install phase):
 *   Failing install because of stray top-level files in site-packages
```
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ae18e3) 80.00% compared to head (3f08bf0) 80.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files          77       77           
  Lines        3560     3560           
=======================================
  Hits         2848     2848           
  Misses        712      712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julius2342 Julius2342 merged commit eabece3 into Julius2342:master Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants