Klf200 class with new frames, reorganisation of files #56

icommitdesnet · 2020-11-24T18:31:27Z

No description provided.

pyvlx/frames/frame_facory_default.py pyvlx/frames/frame_get_local_time.py pyvlx/frames/frame_get_network_setup.py pyvlx/frames/frame_leave_learn_state.py pyvlx/frames/frame_password_change.py

Add Api Functionality for KLF200 Commands

eg. pyvlx.klf200.reboot reboots the gateway update pyvlx functions as wrapper for klf200 object

Julius2342 · 2020-11-24T22:34:14Z

uh, this is a large one... :) Thank you very much!

The PR is marked as draft - tell me when the PR is in a state when it is worth having a deeper look.

Best

icommitdesnet · 2020-11-25T06:39:41Z

Sorry - smaller chuncks in PR next time
Build check failes. Have to adapt Imports of test modules/classes too. Hope to get that right

Greets

coveralls · 2020-11-26T18:54:55Z

Coverage increased (+0.01%) to 81.631% when pulling 804ccfa on icommitdesnet:master into f579c06 on Julius2342:master.

Julius2342 · 2020-12-04T12:23:15Z

pyvlx/scene.py

@@ -39,7 +39,9 @@ async def run(self, wait_for_completion=True):

    def __str__(self):
        """Return object as readable string."""
-        return '<Scene name="{0}" ' 'id="{1}" />'.format(self.name, self.scene_id)
+        return '<{} name="{}" id="{}"/>'.format(


What about using fancy python format strings here? (I would also be fine if we do this in a separate step)

hope, i get you right.
it was inconsistent with single or double quotes (see eg. pyvlx/api/frames/frame_set_node_name.py)
i added type(self).name is because i am lazy and dont want to type too much

seperate steps is maybe the main thing in this pr. too many things together

Yes, fully agree. It is a good improvement. I just thought of using:

return f'<{type(self).__name__} name="{self.name}" id="{self.scene_id}"/>'

But im not sure if this is an improvement...

nah. this is a mess. i should be even more strict
return '<{0} name="{1}" id="{2}"/>'.format( ...

pyvlx/api/frames/frame_activate_scene.py

pyvlx/pyvlx.py

Julius2342

Ugh, what a large PR! Thank you, all looks good to me.

I assume you tested all the changes locally (besides unit tests...)?

Julius2342 · 2020-12-04T13:08:39Z

Another question, do you have any idea how to approach this "KLF 200 hangs" problem?

icommitdesnet · 2020-12-04T14:38:55Z

Ugh, what a large PR! Thank you, all looks good to me.

I assume you tested all the changes locally (besides unit tests...)?

those were easy to test with my klf200

icommitdesnet · 2020-12-04T15:39:21Z

Another question, do you have any idea how to approach this "KLF 200 hangs" problem?

#30 ?

I currently use https://github.com/MiSchroe/ioBroker.klf200 which is restarted by default at 03:00 every day. maybe the same problems there?

Julius2342 · 2020-12-04T15:54:40Z

Another question, do you have any idea how to approach this "KLF 200 hangs" problem?

#30 ?

I currently use https://github.com/MiSchroe/ioBroker.klf200 which is restarted by default at 03:00 every day. maybe the same problems there?

Yup. This seems like the same root cause. There is also a PR in Hass requesting this feature: https://github.com/home-assistant/core/pull/43198/files

icommitdesnet · 2020-12-04T18:28:02Z

Another question, do you have any idea how to approach this "KLF 200 hangs" problem?

#30 ?
I currently use https://github.com/MiSchroe/ioBroker.klf200 which is restarted by default at 03:00 every day. maybe the same problems there?

Yup. This seems like the same root cause. There is also a PR in Hass requesting this feature: https://github.com/home-assistant/core/pull/43198/files

my first considerations:
i cannot reproduce these symptoms with tcp connection only. good.
according to other posts, it needs ungracefully finished ssl connections (dont know ssl connection states and those sessionids, thou)

but: its not the same situation as restart of HA, but i can even influcence an active connection from pyvlx or iobroker klf200.0 by killing just another connection:
a) kill gnutls-cli -V -s -p 51200 myklf may need some tries (<5)
b) wait for pyvlx heartbeat: <FrameGetStateRequest/> does not timeout and it is not possible to exit my main loop
c) try to connect with openssl: fails at ssl handshake. openssl seems to wait forever here.

$ openssl s_client -connect myklf:51200 -state
CONNECTED(00000003)
SSL_connect:before SSL initialization
SSL_connect:SSLv3/TLS write client hello

d) wait a bit and try openssl again -> works

icommitdesnet · 2020-12-04T18:35:14Z

Another question, do you have any idea how to approach this "KLF 200 hangs" problem?

#30 ?
I currently use https://github.com/MiSchroe/ioBroker.klf200 which is restarted by default at 03:00 every day. maybe the same problems there?

Yup. This seems like the same root cause. There is also a PR in Hass requesting this feature: https://github.com/home-assistant/core/pull/43198/files

my first considerations:
i cannot reproduce these symptoms with tcp connection only. good.
according to other posts, it needs ungracefully finished ssl connections (dont know ssl connection states and those sessionids, thou)

but: its not the same situation as restart of HA, but i can even influcence an active connection from pyvlx or iobroker klf200.0 by killing just another connection:
a) kill gnutls-cli -V -s -p 51200 myklf may need some tries (<5)
b) wait for pyvlx heartbeat: <FrameGetStateRequest/> does not timeout and it is not possible to exit my main loop
c) try to connect with openssl: fails at ssl handshake. openssl seems to wait forever here.

$ openssl s_client -connect myklf:51200 -state
CONNECTED(00000003)
SSL_connect:before SSL initialization
SSL_connect:SSLv3/TLS write client hello

d) wait a bit and try openssl again -> works

this is exactly what

ConnectionAbortedError: SSL handshake is taking longer than 60.0 seconds: aborting the connection

says in #30

setting ssl handshake timeout and permanently retrying should do the job imho

pawlizio

There are a lot of changes in this one PR.

pawlizio · 2020-12-04T17:20:40Z

pyvlx/klf200gateway.py

+        leave_learn_state = LeaveLearnState(pyvlx=self.pyvlx)
+        await leave_learn_state.do_api_call()
+        if not leave_learn_state.success:
+            PYVLXLOG.warning("Unable to leave learn state")


Is there a reason why some methods raise an exception and some only log a warning? I think this can be aligned.

aligned: raise pyvlx exceptions on api unsuccessful
fixed: LeaveLearnStateConfirmationStatus does not influcence Status
but arises question: should GW_ERROR_NTF be handled in any way?

pyvlx/pyvlx.py

Remove pyvlx.update_version

All raise exceptions now

…rnstate any more

Julius2342 · 2020-12-06T13:43:19Z

@icommitdesnet : Just tell me when you are ready, then I do a last round of reviews...

icommitdesnet · 2020-12-07T14:49:06Z

@icommitdesnet : Just tell me when you are ready, then I do a last round of reviews...

I think this one is ok now.

Julius2342 · 2020-12-21T08:24:13Z

Thank you very much!

icommitdesnet added 20 commits November 21, 2020 09:52

Edit description

42561fa

Add Frame Definitions for

9ef18bf

pyvlx/frames/frame_facory_default.py pyvlx/frames/frame_get_local_time.py pyvlx/frames/frame_get_network_setup.py pyvlx/frames/frame_leave_learn_state.py pyvlx/frames/frame_password_change.py

Edit Typo

164e7bb

add new Frames

a3a763f

Edit Typo

5f6fd98

Edit Typo

df6b0a4

Add new Frames to Package and Factory

0c1758e

Remove Whitspace

9e0f291

Move Class AliasArray to Frame Package

838a32f

Change Structure to ApiEvent > Frames

780cae8

Add Api Functionality for KLF200 Commands

Fix pylint warnings in ApiEvents (except line too long)

0428199

Add Dataobjects to ApiEvents

c238da2

add klf200 Gateway Class

4c6a4e4

Merge UTC Frame REQ and CFM into one Module

fd92754

Fix SET UTC Call and switch from Login to Password Enter API

472089e

Fixed imports

7f05406

Integrate new KLF200 Class into Pyvlx.

b604cdc

eg. pyvlx.klf200.reboot reboots the gateway update pyvlx functions as wrapper for klf200 object

Unified Human readalbe String generation in Frames

3dd81e5

Add missing humanreadable frame updates

b5a16ab

Change Human Readable String generation for API and Base

5e1775f

icommitdesnet added 5 commits November 25, 2020 18:37

Edit Import for Testclasses

02adcde

Fix Frame

343ccbb

Fix Test Classes

31d9e24

Fix another Typo in Test Class

da5308d

Another Fix for Testclasses Checks for Stringrepresentations

1310f15

icommitdesnet added 2 commits November 26, 2020 22:02

add Test Classes for new Frames

ac7f686

Fix new Frames

0e25e22

icommitdesnet added 2 commits December 4, 2020 08:40

Fix: add tzinfo for testcase

21e1b7e

fix linting

0e827b5

Julius2342 reviewed Dec 4, 2020

View reviewed changes

pyvlx/api/frames/frame_activate_scene.py Outdated Show resolved Hide resolved

Add Test fro PasswordChangeConfirmation

d82760a

Julius2342 reviewed Dec 4, 2020

View reviewed changes

pyvlx/pyvlx.py Outdated Show resolved Hide resolved

Julius2342 reviewed Dec 4, 2020

View reviewed changes

pyvlx/pyvlx.py Show resolved Hide resolved

Julius2342 approved these changes Dec 4, 2020

View reviewed changes

icommitdesnet added 2 commits December 4, 2020 15:12

use Absolute Imports

973ca15

remove duplicate getnetworksetup

2a6912e

pawlizio approved these changes Dec 4, 2020

View reviewed changes

pawlizio reviewed Dec 4, 2020

View reviewed changes

pyvlx/pyvlx.py Show resolved Hide resolved

icommitdesnet added 5 commits December 5, 2020 09:36

Fix logging

9a6ab89

Remove pyvlx.update_version

Align behaviour on unsucessful api calls

ae1b84a

All raise exceptions now

Fix: Api Success, if Framehandling is OK. Does not depend on leavelea…

12ffa18

…rnstate any more

Fix: remove connection=false. Api should timeout

8689fc5

Fix unused imports

673c177

Remove unnecessary Output

804ccfa

pawlizio approved these changes Dec 20, 2020

View reviewed changes

Julius2342 merged commit a1c4419 into Julius2342:master Dec 21, 2020

jirkapas mentioned this pull request Apr 21, 2021

Bump pyvlx to 0.2.19 home-assistant/core#49533

Merged

21 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Klf200 class with new frames, reorganisation of files #56

Klf200 class with new frames, reorganisation of files #56

icommitdesnet commented Nov 24, 2020

Julius2342 commented Nov 24, 2020 •

edited

icommitdesnet commented Nov 25, 2020

coveralls commented Nov 26, 2020 •

edited

Julius2342 Dec 4, 2020

icommitdesnet Dec 4, 2020

Julius2342 Dec 4, 2020

icommitdesnet Dec 4, 2020

Julius2342 left a comment

Julius2342 commented Dec 4, 2020

icommitdesnet commented Dec 4, 2020 •

edited

icommitdesnet commented Dec 4, 2020

Julius2342 commented Dec 4, 2020

icommitdesnet commented Dec 4, 2020

icommitdesnet commented Dec 4, 2020

pawlizio left a comment

pawlizio Dec 4, 2020

icommitdesnet Dec 5, 2020

Julius2342 commented Dec 6, 2020

icommitdesnet commented Dec 7, 2020

Julius2342 commented Dec 21, 2020

Klf200 class with new frames, reorganisation of files #56

Klf200 class with new frames, reorganisation of files #56

Conversation

icommitdesnet commented Nov 24, 2020

Julius2342 commented Nov 24, 2020 • edited

icommitdesnet commented Nov 25, 2020

coveralls commented Nov 26, 2020 • edited

Julius2342 Dec 4, 2020

Choose a reason for hiding this comment

icommitdesnet Dec 4, 2020

Choose a reason for hiding this comment

Julius2342 Dec 4, 2020

Choose a reason for hiding this comment

icommitdesnet Dec 4, 2020

Choose a reason for hiding this comment

Julius2342 left a comment

Choose a reason for hiding this comment

Julius2342 commented Dec 4, 2020

icommitdesnet commented Dec 4, 2020 • edited

icommitdesnet commented Dec 4, 2020

Julius2342 commented Dec 4, 2020

icommitdesnet commented Dec 4, 2020

icommitdesnet commented Dec 4, 2020

pawlizio left a comment

Choose a reason for hiding this comment

pawlizio Dec 4, 2020

Choose a reason for hiding this comment

icommitdesnet Dec 5, 2020

Choose a reason for hiding this comment

Julius2342 commented Dec 6, 2020

icommitdesnet commented Dec 7, 2020

Julius2342 commented Dec 21, 2020

Julius2342 commented Nov 24, 2020 •

edited

coveralls commented Nov 26, 2020 •

edited

icommitdesnet commented Dec 4, 2020 •

edited