Support for Dual Roller Shutter #66
Conversation
|
The question remains, how to integrate with home assistant. I still believe that simply adding a "curtain" parameter to the cover.set_position function would be sufficient and simpler then exposing three covers to home assistant (as discussed in 2019). I did not explore whether/how KLF 200 reports position changes on the sub-covers. I'm not sure whether we would be able to maintain the correct position of these sub-covers in home assistant. Thus only providing a one-way function call to set the position of the sub-curtains seems to be perfectly fine for me. |
|
Looks good to me. I think it is fine to add pylint-ignore for the too-many-branches and too-many-return statements warning. And I would like to ask you to add a unit test :-) |
pyvlx/opening_device.py
Outdated
| """Dual RollerShutter object.""" | ||
|
|
||
| async def set_position(self, position, wait_for_completion=True, curtain="both"): | ||
| """Set dual roller shutter to the desired position. |
There was a problem hiding this comment.
The problem here is, that this definition conflichts with the base implementation. I think the way around it could be to add a **kwargs to the base class (not a big fan of this approach, bc it makes refactoring hard).
Another idea would be to add an additional method to the DualRollerShutter.
Support for separately positioning the upper or lower curtain of dual roller shutters added.