Improvement of percent calculation

[Nicks57]

Improvement of percent calculation in to_percent() for devices that do not return exactly 51200 as final position when closed.

Fixes #47

[Julius2342]

Thank you :) May I also ask you to add some unit tests (to catch esp edge cases around the maximum and mimimum values.)

You could test e.g. raw values for: 0,1,3,100,198,199,200.

Another question, don't we have to update the from_percent function as well?

[Nicks57]

Your welcome :-)

I assume from_percent is used to convert an input command received (e.g. from Home Assistant) to raw (byte array) to send it to KLF200. Since this command will always be accurate (0%-100% i.e. 0-51200) there is no need to add tolerance. The tolerance is only here to compensate the response of Velux Motor that drift slightly from the set_position command.

Can you please advise me how to do and publish the unit tests?

Thank you!

[Julius2342]

An example for a unit test you can see here: https://github.com/Julius2342/pyvlx/blob/master/test/alias_array_test.py

It tests the function on a low level (and ensures that the functionality stays the same even after refactorings which happen in the future)

[Julius2342]

Hey @Nicks57 , i added the github integration for an automatic execution of unit tests. May I ask you to rebase or merge master?

[Nicks57]

Hi Julius!
I merged the master in my fork and added unit test file parameter_test.py. Are the tests ok?

[Julius2342]

Please run isort test/parameter_test.py . And pyvlx.exception.PyVLXException has to be removed.

The rest looks fine ...

[Nicks57]

Done! Thank you for your help.

[codecov-commenter]

Codecov Report

Merging #72 (3aca264) into master (869029f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   81.79%   81.79%           
=======================================
  Files          73       73           
  Lines        2967     2967           
=======================================
  Hits         2427     2427           
  Misses        540      540           

Impacted Files	Coverage Δ
pyvlx/parameter.py	85.93% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869029f...3aca264. Read the comment docs.

[Julius2342]

Thank you @Nicks57 :)